----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34536/#review84873 -----------------------------------------------------------
Thanks for working on this. It seems like a nice feature to add. I have a couple of nits src/docs/user/import.txt <https://reviews.apache.org/r/34536/#comment136292> Nit. Please say that this only applies to integer and date datatypes here src/java/org/apache/sqoop/tool/ImportTool.java <https://reviews.apache.org/r/34536/#comment136379> Nit. May be edit the description to say "Upper limit of rows per split for split columns of Date/Time/Timestamp and integer types. Also, can you add a small validation to say split size cannot be less than 0 (as we use 0 to say no split limit). - Venkat Ranganathan On May 22, 2015, 12:45 a.m., Rakesh Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34536/ > ----------------------------------------------------------- > > (Updated May 22, 2015, 12:45 a.m.) > > > Review request for Sqoop and Venkat Ranganathan. > > > Repository: sqoop-trunk > > > Description > ------- > > This is the review request for Apache jira : SQOOP-2334. > > > Diffs > ----- > > src/docs/man/import-args.txt 93f65ba > src/docs/user/import.txt a6b23df > src/java/org/apache/sqoop/SqoopOptions.java 0070d0b > src/java/org/apache/sqoop/config/ConfigurationConstants.java 2070b63 > src/java/org/apache/sqoop/config/ConfigurationHelper.java 5e4230e > src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 708da5b > src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 2c59fe5 > src/java/org/apache/sqoop/mapreduce/db/DateSplitter.java 31e9351 > src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java e6fefc6 > src/java/org/apache/sqoop/tool/BaseSqoopTool.java b41ee2d > src/java/org/apache/sqoop/tool/ImportTool.java d5bf1eb > src/test/org/apache/sqoop/mapreduce/db/TestIntegerSplitter.java 136afc7 > > Diff: https://reviews.apache.org/r/34536/diff/ > > > Testing > ------- > > YES > > > Thanks, > > Rakesh Sharma > >
