----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34536/#review89375 -----------------------------------------------------------
src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java (line 80) <https://reviews.apache.org/r/34536/#comment141955> What happens when we call getSplitter(DECIMAL|BOOLEAN) etc? You call the new method with the splitLimit as 0. But then, if the limit is 0, this exception is thrown if(splitLimit >= 0) { throw new IllegalArgumentException("split-limit is supported only with Integer and Date columns"); } How is this supposed to work with old method? Doesn't it break backward compatibility for OracleDataDrivenDBInputFormat - Venkat Ranganathan On June 23, 2015, 1:20 a.m., Rakesh Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34536/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 1:20 a.m.) > > > Review request for Sqoop and Venkat Ranganathan. > > > Repository: sqoop-trunk > > > Description > ------- > > This is the review request for Apache jira : SQOOP-2334. > > > Diffs > ----- > > src/docs/man/import-args.txt 93f65ba > src/docs/user/import.txt df04157 > src/java/org/apache/sqoop/SqoopOptions.java ef6e0ce > src/java/org/apache/sqoop/config/ConfigurationConstants.java 2070b63 > src/java/org/apache/sqoop/config/ConfigurationHelper.java 8dc2061 > src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 7521464 > src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 2c59fe5 > src/java/org/apache/sqoop/mapreduce/db/DateSplitter.java 31e9351 > src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java e6fefc6 > src/java/org/apache/sqoop/tool/BaseSqoopTool.java c97bb58 > src/java/org/apache/sqoop/tool/ImportTool.java c79e044 > src/test/org/apache/sqoop/mapreduce/db/TestIntegerSplitter.java 136afc7 > > Diff: https://reviews.apache.org/r/34536/diff/ > > > Testing > ------- > > YES > > > Thanks, > > Rakesh Sharma > >
