----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34971/#review86370 -----------------------------------------------------------
server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java <https://reviews.apache.org/r/34971/#comment138348> How about adding this resource check to revoke function as well? The privilege could be null, it will revoke all privileges from this principal. But if there is a privilege, then check whether this privilege exists or not. server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java <https://reviews.apache.org/r/34971/#comment138343> Please add a comment //The default is for MResource Type (SERVER). This resource must exist. - richard zhou On June 3, 2015, 1:10 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34971/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 1:10 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Check whether resource exists before run privilege check, including > grant/check_privilege. If resource does not exists, throw "none resource > exception" > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java > e5fbe2d > > server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java > 00f4b52 > > Diff: https://reviews.apache.org/r/34971/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
