> On June 4, 2015, 9:15 a.m., Abraham Elmahrek wrote: > > server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java, > > line 181 > > <https://reviews.apache.org/r/34971/diff/2/?file=977311#file977311line181> > > > > This should throw an exception. Maybe do some exception handling > > instead?
Have created SQOOP-2390 for this issue. > On June 4, 2015, 9:15 a.m., Abraham Elmahrek wrote: > > server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java, > > line 185 > > <https://reviews.apache.org/r/34971/diff/2/?file=977311#file977311line185> > > > > This should throw an exception. Maybe do some exception handling > > instead? Have created SQOOP-2390 for this issue. > On June 4, 2015, 9:15 a.m., Abraham Elmahrek wrote: > > server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java, > > line 189 > > <https://reviews.apache.org/r/34971/diff/2/?file=977311#file977311line189> > > > > This should throw an exception. Maybe do some exception handling > > instead? Have created SQOOP-2390 for this issue. - Dian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34971/#review86580 ----------------------------------------------------------- On June 4, 2015, 11:25 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34971/ > ----------------------------------------------------------- > > (Updated June 4, 2015, 11:25 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Check whether resource exists before run privilege check, including > grant/check_privilege. If resource does not exists, throw "none resource > exception" > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java > e5fbe2d > > server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java > 00f4b52 > > Diff: https://reviews.apache.org/r/34971/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
