Fixed the check style issues suggested by you. Thanks and Regards, Rakesh.
From: Venkat Ranganathan <[email protected]<mailto:[email protected]>> on behalf of Venkat Ranganathan <[email protected]<mailto:[email protected]>> Reply-To: Venkat Ranganathan <[email protected]<mailto:[email protected]>> Date: Monday, June 29, 2015 at 10:55 AM To: Venkat Ranganathan <[email protected]<mailto:[email protected]>> Cc: Sqoop <[email protected]<mailto:[email protected]>>, Rakesh Sharma <[email protected]<mailto:[email protected]>> Subject: Re: Review Request 34536: Review Request for Volume per mapper patch(SQOOP-2334) This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34536/ Looks good to commit. Found a few checkstyle issues. Please fix them. Also, you have not closed the earlier issue after fixing it src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java<https://reviews.apache.org/r/34536/diff/7/?file=994099#file994099line91>(Diff revision 7) public class DataDrivenDBInputFormat<T extends DBWritable> 91 if(splitLimit > 0) { Minor Nit: No space after if. It violates the checkstyle rules. Same issue in the other similar checks src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java<https://reviews.apache.org/r/34536/diff/7/?file=994101#file994101line66>(Diff revision 7) public class IntegerSplitter implements DBSplitter { 64 List<Long> splitPoints = split(numSplits, minVal, maxVal); 66 List<Long> splitPoints = split(numSplits,splitLimit, minVal, maxVal); Minor Checkstyle Nit: Need space after , in ,speedLimit src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java<https://reviews.apache.org/r/34536/diff/7/?file=994101#file994101line125>(Diff revision 7) public class IntegerSplitter implements DBSplitter { 116 public List<Long> split(long numSplits, long minVal, long maxVal) 125 public List<Long> split(long numSplits,long splitLimit, long minVal, long maxVal) Same as above - Venkat Ranganathan On June 28th, 2015, 4:21 a.m. PDT, Rakesh Sharma wrote: Review request for Sqoop and Venkat Ranganathan. By Rakesh Sharma. Updated June 28, 2015, 4:21 a.m. Repository: sqoop-trunk Description This is the review request for Apache jira : SQOOP-2334. Testing YES Diffs * src/docs/man/import-args.txt (93f65ba) * src/docs/user/import.txt (df04157) * src/java/org/apache/sqoop/SqoopOptions.java (ef6e0ce) * src/java/org/apache/sqoop/config/ConfigurationConstants.java (2070b63) * src/java/org/apache/sqoop/config/ConfigurationHelper.java (8dc2061) * src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java (7521464) * src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java (2c59fe5) * src/java/org/apache/sqoop/mapreduce/db/DateSplitter.java (31e9351) * src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java (e6fefc6) * src/java/org/apache/sqoop/tool/BaseSqoopTool.java (c97bb58) * src/java/org/apache/sqoop/tool/ImportTool.java (c79e044) * src/test/org/apache/sqoop/mapreduce/db/TestIntegerSplitter.java (136afc7) View Diff<https://reviews.apache.org/r/34536/diff/>
