----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34588/#review89962 -----------------------------------------------------------
Ship it! Thanks for the patch and sorry for the very late review. Looks good - just two minor comments. src/docs/user/connectors.txt (lines 418 - 424) <https://reviews.apache.org/r/34588/#comment142865> The description here is probably wrong... looks like a copy-paste issue. src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableExportMapper.java (lines 102 - 105) <https://reviews.apache.org/r/34588/#comment142867> Do we want to validate values of line separator somewhere around here? Since a line separator of "cr" will not work, we should probably make sure we give a reasonable error if the user didn't configure something different. - Gwen Shapira On May 22, 2015, 6:43 a.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34588/ > ----------------------------------------------------------- > > (Updated May 22, 2015, 6:43 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-trunk > > > Description > ------- > > Add support for two new options --crin-string and --ignore-zero which allows > Carriage return as well as cause Netezza to ignore NUL when processing load. > > Added documentation and fixed some existing documentation regarding > applicability of options > > > Diffs > ----- > > src/docs/user/connectors.txt 496d3cf > src/java/org/apache/sqoop/manager/DirectNetezzaManager.java 06fa976 > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableExportMapper.java > f377fb9 > > Diff: https://reviews.apache.org/r/34588/diff/ > > > Testing > ------- > > Ran tests with all the options and validated the crinstring and ignore-zero > works > > > Thanks, > > Venkat Ranganathan > >
