> On June 30, 2015, 1:41 p.m., Gwen Shapira wrote: > > Thanks for the patch and sorry for the very late review. > > > > Looks good - just two minor comments.
No worries Gwen. > On June 30, 2015, 1:41 p.m., Gwen Shapira wrote: > > src/docs/user/connectors.txt, lines 418-424 > > <https://reviews.apache.org/r/34588/diff/1/?file=969016#file969016line418> > > > > The description here is probably wrong... looks like a copy-paste issue. Thanks Gwen for the review. Good catch Gwen. Will fix > On June 30, 2015, 1:41 p.m., Gwen Shapira wrote: > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableExportMapper.java, > > lines 102-105 > > <https://reviews.apache.org/r/34588/diff/1/?file=969018#file969018line102> > > > > Do we want to validate values of line separator somewhere around here? > > Since a line separator of "cr" will not work, we should probably make sure > > we give a reasonable error if the user didn't configure something different. This option is provided to Netezza and the input file is handled by Netezza. So, not sure if we can validate it. This is only added as an option so the assumption is the user uses this only if they have cr in their string and they don't want it to be treated as a line terminator - Venkat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34588/#review89962 ----------------------------------------------------------- On May 21, 2015, 11:43 p.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34588/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 11:43 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-trunk > > > Description > ------- > > Add support for two new options --crin-string and --ignore-zero which allows > Carriage return as well as cause Netezza to ignore NUL when processing load. > > Added documentation and fixed some existing documentation regarding > applicability of options > > > Diffs > ----- > > src/docs/user/connectors.txt 496d3cf > src/java/org/apache/sqoop/manager/DirectNetezzaManager.java 06fa976 > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableExportMapper.java > f377fb9 > > Diff: https://reviews.apache.org/r/34588/diff/ > > > Testing > ------- > > Ran tests with all the options and validated the crinstring and ignore-zero > works > > > Thanks, > > Venkat Ranganathan > >
