----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34507/#review91111 -----------------------------------------------------------
Overall, looks good, thank you for working on this one Abe! I have just one comment: test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java (lines 150 - 155) <https://reviews.apache.org/r/34507/#comment144376> Perhaps I've missed something, but HadoopProvider doesn't seem to be added to the PROVIDERS group, so it's probably not properly stopped, right? Jarcec - Jarek Cecho On July 7, 2015, 10:20 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34507/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 10:20 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2365 > https://issues.apache.org/jira/browse/SQOOP-2365 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit bd1fbb96d76cea7ec1a3039b73aa9553576166f1 > Author: Abraham Elmahrek <[email protected]> > Date: Fri May 15 16:10:17 2015 -0700 > > SQOOP-2364: Sqoop2: Provide test infrastructure base class for server > tests > > :000000 100644 0000000... f3db7ad... A > test/src/main/java/org/apache/sqoop/test/infrastructure/Infrastructure.java > :000000 100644 0000000... 6fb1eac... A > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java > :000000 100644 0000000... 5b4f595... A > test/src/main/java/org/apache/sqoop/test/infrastructure/providers/SqoopInfrastructureProvider.java > > > Diffs > ----- > > test/src/main/java/org/apache/sqoop/test/infrastructure/Infrastructure.java > PRE-CREATION > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/34507/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Abraham Elmahrek > >
