> On July 9, 2015, 4:13 p.m., Jarek Cecho wrote:
> > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java,
> > lines 150-155
> > <https://reviews.apache.org/r/34507/diff/2/?file=1001813#file1001813line150>
> >
> > Perhaps I've missed something, but HadoopProvider doesn't seem to be
> > added to the PROVIDERS group, so it's probably not properly stopped, right?
I believe it is added. The method `startInfrastructureProvider` adds providers
to the PROVIDERS group. Here's the code that starts all providers:
// Start hadoop first.
if (providers.contains(HadoopInfrastructureProvider.class)) {
InfrastructureProvider hadoopProviderObject =
startInfrastructureProvider(HadoopInfrastructureProvider.class, conf);
// Use the prepared hadoop configuration for the rest of the components.
if (hadoopProviderObject != null) {
conf = hadoopProviderObject.getHadoopConfiguration();
}
}
// Start the rest of the providers.
for (Class<? extends InfrastructureProvider> provider : providers) {
startInfrastructureProvider(provider, conf);
}
Notice how `startInfrastructureProvider` is called first on
`HadoopInfrastructureProvider.class`.
I'll add some comments to clarify this. Thanks for pointing this out!
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34507/#review91111
-----------------------------------------------------------
On July 7, 2015, 10:20 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34507/
> -----------------------------------------------------------
>
> (Updated July 7, 2015, 10:20 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2365
> https://issues.apache.org/jira/browse/SQOOP-2365
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit bd1fbb96d76cea7ec1a3039b73aa9553576166f1
> Author: Abraham Elmahrek <[email protected]>
> Date: Fri May 15 16:10:17 2015 -0700
>
> SQOOP-2364: Sqoop2: Provide test infrastructure base class for server
> tests
>
> :000000 100644 0000000... f3db7ad... A
> test/src/main/java/org/apache/sqoop/test/infrastructure/Infrastructure.java
> :000000 100644 0000000... 6fb1eac... A
> test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java
> :000000 100644 0000000... 5b4f595... A
> test/src/main/java/org/apache/sqoop/test/infrastructure/providers/SqoopInfrastructureProvider.java
>
>
> Diffs
> -----
>
> test/src/main/java/org/apache/sqoop/test/infrastructure/Infrastructure.java
> PRE-CREATION
> test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34507/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
