----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37120/#review94508 -----------------------------------------------------------
Ship it! For MySQL, backticks are used by default for table or column identifiers. Backticks are necessary only when the identifier is a MySQL reserved keyword, or when the identifier contains whitespace characters or characters beyond a limited set. As for SQOOP, the table or column identifiers don't belong to such cases, so it's fine to make table or column identifiers without wrapped by quotes or backticks. But we should make table or column identifiers still wrapped with double-quotes for Derby and PostgreSQL as double-quotes also means case sensitive for these databases. As confirmed with you offline that we will still use double-quotes for Derby and PostgreSQL, so I'm +1 for this patch. - Dian Fu On Aug. 5, 2015, 7:35 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37120/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 7:35 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Currently, in the class CommonRepositoryInsertUpdateDeleteSelectQuery, the > tableName and columnName are wrapped with quotation, like > "tableName"."columnName". But some db doesn't support this format, like MySql. > Refactor the code in repository-common to fix this problem. > > > Diffs > ----- > > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java > 73293c0 > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java > 1b5e2fb > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java > 28f5f6a > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/RepositoryQuery.java > PRE-CREATION > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 2ba3384 > > Diff: https://reviews.apache.org/r/37120/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
