----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37120/#review95905 -----------------------------------------------------------
Ship it! Seems fine... just kill the interface! repository/repository-common/src/main/java/org/apache/sqoop/repository/common/RepositoryQuery.java (line 21) <https://reviews.apache.org/r/37120/#comment151106> This is really only for JDBC repositories. I don't think we need RepositoryQuery as much as need CommonRepositoryInsertUpdateDeleteSelectQuery. Seems like an interface for no reason. - Abraham Elmahrek On Aug. 10, 2015, 8:08 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37120/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2015, 8:08 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Currently, in the class CommonRepositoryInsertUpdateDeleteSelectQuery, the > tableName and columnName are wrapped with quotation, like > "tableName"."columnName". But some db doesn't support this format, like MySql. > Refactor the code in repository-common to fix this problem. > > > Diffs > ----- > > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java > 1b5e2fb > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java > 28f5f6a > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/RepositoryQuery.java > PRE-CREATION > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 2ba3384 > > Diff: https://reviews.apache.org/r/37120/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
