> On Aug. 12, 2015, 5:05 a.m., Dian Fu wrote: > > > > Dian Fu wrote: > Overall the patch LGTM. Just one minor issue. +1 if the following issue > is fixed.
Thank you for the review Dian! > On Aug. 12, 2015, 5:05 a.m., Dian Fu wrote: > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java, > > line 400 > > <https://reviews.apache.org/r/37380/diff/1/?file=1038021#file1038021line400> > > > > should check if rs == null. I was looking into JDBC spec [1] and appareantly the call getPrimaryKeys() will never return null - it will throw a SQLException on error instead. Hence I've intentionally removed that check. I guess that I can add it if we feel too strongly about that. What do you think? Links: 1: http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getPrimaryKeys(java.lang.String,%20java.lang.String,%20java.lang.String) - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37380/#review95055 ----------------------------------------------------------- On Aug. 12, 2015, 2:18 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37380/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2015, 2:18 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2443 > https://issues.apache.org/jira/browse/SQOOP-2443 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Added support for compound primary key in to the Generic JDBC Executor. > > > Diffs > ----- > > > common/src/main/java/org/apache/sqoop/error/code/GenericJdbcConnectorError.java > f18acbd > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java > 1aeca7e > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java > 9d8e4e7 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java > a482ac4 > > Diff: https://reviews.apache.org/r/37380/diff/ > > > Testing > ------- > > Unit and integration tests seems to be passing. > > > Thanks, > > Jarek Cecho > >
