> On Aug. 12, 2015, 7:13 p.m., Abraham Elmahrek wrote: > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java, > > line 145 > > <https://reviews.apache.org/r/37380/diff/1/?file=1038022#file1038022line145> > > > > Wondering if we can add debug logging about which primary key column > > was used specifically.
Good point - we already have that on line 153 :) > On Aug. 12, 2015, 7:13 p.m., Abraham Elmahrek wrote: > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java, > > line 138 > > <https://reviews.apache.org/r/37380/diff/1/?file=1038022#file1038022line138> > > > > Wondering if we should add debug logging about what primary keys were > > found. Good point, I'll definitely add it. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37380/#review95146 ----------------------------------------------------------- On Aug. 12, 2015, 2:18 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37380/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2015, 2:18 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2443 > https://issues.apache.org/jira/browse/SQOOP-2443 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Added support for compound primary key in to the Generic JDBC Executor. > > > Diffs > ----- > > > common/src/main/java/org/apache/sqoop/error/code/GenericJdbcConnectorError.java > f18acbd > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java > 1aeca7e > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java > 9d8e4e7 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java > a482ac4 > > Diff: https://reviews.apache.org/r/37380/diff/ > > > Testing > ------- > > Unit and integration tests seems to be passing. > > > Thanks, > > Jarek Cecho > >
