[
https://issues.apache.org/jira/browse/SQOOP-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746635#comment-14746635
]
Sqoop QA bot commented on SQOOP-2464:
-------------------------------------
Testing file
[SQOOP-2464.patch|https://issues.apache.org/jira/secure/attachment/12756127/SQOOP-2464.patch]
against branch sqoop2 took 0:53:30.092794.
{color:red}Overall:{color} -1 due to an error(s), see details below:
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:red}ERROR:{color} Patch does not add/modify any test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1432 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1691/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1691/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 79 tests)
Console output is available
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1691/console].
This message is automatically generated.
> Initializer object is not reused when calling getSchema
> -------------------------------------------------------
>
> Key: SQOOP-2464
> URL: https://issues.apache.org/jira/browse/SQOOP-2464
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.99.6
> Reporter: David Robson
> Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2464.patch
>
>
> In JobManager there is two methods which are called one after the other -
> "initializeConnector" and "getSchemaForConnector". Both these methods do the
> same thing as the first step - create a new instance of the initializer class.
> If the same instance of the initializer was shared it means the class could
> keep resources open (such as a connection to the database) and not have to
> re-establish the connection. This might mean a close method needs to be added
> to the initializers as otherwise the getSchema would need to close any
> resources opened in the initialize call - which might seem a bit confusing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
