[
https://issues.apache.org/jira/browse/SQOOP-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790711#comment-14790711
]
Jarek Jarcec Cecho commented on SQOOP-2464:
-------------------------------------------
After further thinking I've realized that my request to test this is hard to
accomplish, so properly documenting that all methods in {{Initializer}} are run
from the same instance is sufficient from my side.
For the precommit hook - I found it positive that the patch works without
changing any tests, so +1 from my side and overriding the precommit hook -1.
> Initializer object is not reused when calling getSchema
> -------------------------------------------------------
>
> Key: SQOOP-2464
> URL: https://issues.apache.org/jira/browse/SQOOP-2464
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.99.6
> Reporter: David Robson
> Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2464.patch
>
>
> In JobManager there is two methods which are called one after the other -
> "initializeConnector" and "getSchemaForConnector". Both these methods do the
> same thing as the first step - create a new instance of the initializer class.
> If the same instance of the initializer was shared it means the class could
> keep resources open (such as a connection to the database) and not have to
> re-establish the connection. This might mean a close method needs to be added
> to the initializers as otherwise the getSchema would need to close any
> resources opened in the initialize call - which might seem a bit confusing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
