----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39927/#review105075 -----------------------------------------------------------
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java (lines 285 - 286) <https://reviews.apache.org/r/39927/#comment163454> I don't like the idea that we're delaying every single test case for every single repository implementation by 3 seconds only because of one repository implementation. What about fixing the root of the problem rathern just inserting sleep? Would it be fair to assume that the MySQL repository is not fully initialized at the time we're submitting the job? If so, can't we simply not run the test case until the Sqoop 2 server fully started and all is initialized? - Jarek Cecho On Nov. 4, 2015, 1:36 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39927/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 1:36 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > There are 2 problems should be fixed with MySql repository: > 1. Can't detect the repository version correctly. > 2. There should suspend several seconds when execute the job in the > integration test. > > > Diffs > ----- > > > common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java > 268e475 > > common-test/src/main/java/org/apache/sqoop/common/test/repository/MysqlRepositoryProvider.java > 229b339 > > repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlRepositoryHandler.java > fd3a3f2 > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > 8e3d7df > > Diff: https://reviews.apache.org/r/39927/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
