> On Nov. 4, 2015, 4:07 p.m., Jarek Cecho wrote: > > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java, > > lines 285-286 > > <https://reviews.apache.org/r/39927/diff/1/?file=1115324#file1115324line285> > > > > I don't like the idea that we're delaying every single test case for > > every single repository implementation by 3 seconds only because of one > > repository implementation. > > > > What about fixing the root of the problem rathern just inserting sleep? > > Would it be fair to assume that the MySQL repository is not fully > > initialized at the time we're submitting the job? If so, can't we simply > > not run the test case until the Sqoop 2 server fully started and all is > > initialized?
Based on current investigation, if ConnectorTestCase.executeJob called continuesly, there will a problem to select the last submission for a job. Both of the submissions will be updated time by time, and it's hard to pick the last submission according to the update time. Currently, I put the sleep in the specific test case and this won't impact other cases. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39927/#review105075 ----------------------------------------------------------- On Nov. 5, 2015, 8:38 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39927/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 8:38 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > There are 2 problems should be fixed with MySql repository: > 1. Can't detect the repository version correctly. > 2. There should suspend several seconds when execute the job in the > integration test. > > > Diffs > ----- > > > common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java > 268e475 > > common-test/src/main/java/org/apache/sqoop/common/test/repository/MysqlRepositoryProvider.java > 229b339 > > repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlRepositoryHandler.java > fd3a3f2 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/AppendModeTest.java > 5063a2b > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/HdfsIncrementalReadTest.java > a32a563 > > Diff: https://reviews.apache.org/r/39927/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
