----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40051/#review105706 -----------------------------------------------------------
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java (line 42) <https://reviews.apache.org/r/40051/#comment164311> typo: "did not change" connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java (line 46) <https://reviews.apache.org/r/40051/#comment164314> i think it may be worth writing some kind of helper function for the population of list inputs connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java (line 48) <https://reviews.apache.org/r/40051/#comment164312> String[] columns connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java (line 76) <https://reviews.apache.org/r/40051/#comment164310> no love for isEmpty()? connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java (line 41) <https://reviews.apache.org/r/40051/#comment164318> is a limit of 50 still relevant here? i could imagine users with very wide tables using this functionality. - Abraham Fine On Nov. 7, 2015, 10:40 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40051/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2015, 10:40 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2660 > https://issues.apache.org/jira/browse/SQOOP-2660 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Implemented changes as suggested on JIRA. > > > Diffs > ----- > > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java > 87af723 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java > c2d22f7 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java > fc49061 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java > adbd457 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java > 2384112 > > connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-config.properties > 6defb26 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java > 1c8379d > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java > c53a0b0 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java > 40278b6 > > test/src/test/java/org/apache/sqoop/integration/connector/hive/FromRDBMSToKiteHiveTest.java > 37a0a7d > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java > aece8cf > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java > aa4fdde > > test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java > 71e405b > > Diff: https://reviews.apache.org/r/40051/diff/ > > > Testing > ------- > > All changed tests (unit+integration) seems to be passing. > > > Thanks, > > Jarek Cecho > >
