> On Nov. 9, 2015, 5:57 p.m., Abraham Fine wrote: > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java, > > line 47 > > <https://reviews.apache.org/r/40051/diff/1/?file=1118938#file1118938line47> > > > > i think it may be worth writing some kind of helper function for the > > population of list inputs > > Jarek Cecho wrote: > What are you thinking about? > > I feel that this is more an one-off upgrade path then a pattern. Mainly > because I don't see any existing option that I would split to a List and I'm > hoping that new development will be based directly on the List. > > Abraham Fine wrote: > upgradeFromJobConfig and upgradeToJobConfig seem very similar to me. It > may be worth DRY'ing them out. but it is not a major concern.
I see your point now, seems as far feedback, so I'll incorporate it shortly. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40051/#review105706 ----------------------------------------------------------- On Nov. 10, 2015, 1:35 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40051/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 1:35 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2660 > https://issues.apache.org/jira/browse/SQOOP-2660 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Implemented changes as suggested on JIRA. > > > Diffs > ----- > > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java > 87af723 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java > c2d22f7 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java > fc49061 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java > adbd457 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java > 2384112 > > connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-config.properties > 6defb26 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java > 1c8379d > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java > c53a0b0 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java > 40278b6 > > test/src/test/java/org/apache/sqoop/integration/connector/hive/FromRDBMSToKiteHiveTest.java > 37a0a7d > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java > aece8cf > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java > aa4fdde > > test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java > 71e405b > > Diff: https://reviews.apache.org/r/40051/diff/ > > > Testing > ------- > > All changed tests (unit+integration) seems to be passing. > > > Thanks, > > Jarek Cecho > >
