----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40123/#review105886 -----------------------------------------------------------
Since now we don't have ability to specify the job ID as the way to execute the job, might I suggest to add a test case to our integration test suite that will create link/job name with: spaces, "." and "/", "?" and "&" - e.g. some of the characters that are "special" in URL? I would like to test that we're escaping them properly everywhere. I do not insist on doing that as part of this patch though - having separate task under SQOOP-2674 umbreall is completely fine :) server/src/main/java/org/apache/sqoop/handler/HandlerUtils.java (lines 30 - 38) <https://reviews.apache.org/r/40123/#comment164578> I like how this method is simplified suddenly :) One point though: The client API is calling UrlSafeUtils.urlPathEncode() [1] on the identifier - shouldn't we call decode here? Links: 1: https://github.com/apache/sqoop/blob/sqoop2/client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java#L67 test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java <https://reviews.apache.org/r/40123/#comment164580> Shouldn't we convert this to delete job names rather then dropping it ocmpletely? test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java (lines 157 - 161) <https://reviews.apache.org/r/40123/#comment164582> I would drop the idea of "id" from this test completely and refactore all the methods to use names. - Jarek Cecho On Nov. 10, 2015, 1:43 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40123/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 1:43 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Remove the id from public interface for Job > > > Diffs > ----- > > server/src/main/java/org/apache/sqoop/handler/HandlerUtils.java 69bccf7 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > 6face94 > server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java > 02937bb > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java > 386b701 > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > 8e3d7df > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java > a7be9c6 > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java > 3962449 > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java > 9ee0379 > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_5UpgradeTest.java > 4183d8b > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_6UpgradeTest.java > 59980c0 > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java > 98e1fa1 > > test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java > 93cc7f6 > > Diff: https://reviews.apache.org/r/40123/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
