> On Nov. 10, 2015, 4:07 p.m., Jarek Cecho wrote: > > server/src/main/java/org/apache/sqoop/handler/HandlerUtils.java, lines 30-75 > > <https://reviews.apache.org/r/40123/diff/1/?file=1121222#file1121222line30> > > > > I like how this method is simplified suddenly :) > > > > One point though: The client API is calling > > UrlSafeUtils.urlPathEncode() [1] on the identifier - shouldn't we call > > decode here? > > > > Links: > > 1: > > https://github.com/apache/sqoop/blob/sqoop2/client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java#L67 > > Colin Ma wrote: > I'll fix it.
Check the code again, RequestContext.getLastURLElement or RequestContext.getUrlElements will do the decode for the identity. We needn't do the decode here. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40123/#review105886 ----------------------------------------------------------- On Nov. 10, 2015, 1:43 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40123/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 1:43 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Remove the id from public interface for Job > > > Diffs > ----- > > server/src/main/java/org/apache/sqoop/handler/HandlerUtils.java 69bccf7 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > 6face94 > server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java > 02937bb > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java > 386b701 > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > 8e3d7df > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java > a7be9c6 > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java > 3962449 > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java > 9ee0379 > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_5UpgradeTest.java > 4183d8b > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_6UpgradeTest.java > 59980c0 > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java > 98e1fa1 > > test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java > 93cc7f6 > > Diff: https://reviews.apache.org/r/40123/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
