----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40896/#review109086 -----------------------------------------------------------
It seems that we have a lot of various fixes inside one patch. I hesitate to push this as a single change as we will loose track of why exactly we did those changes. Would you mind splitting each individual fix to it's own JIRA describing what is the problem and hence why we need to fix it? common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java (lines 243 - 247) <https://reviews.apache.org/r/40896/#comment168516> Out of my curiosity - what database throws RuntimeException when dropping non existing table? Shouldn't we catch that inside the dropTable() method? (VERIFY) common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java (lines 353 - 354) <https://reviews.apache.org/r/40896/#comment168517> Will this generally work for all databases that you've mentioned? common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java (lines 67 - 75) <https://reviews.apache.org/r/40896/#comment168518> This seems weird to me - if we need to split something with a dot, then that something is not a table name. It's a database and table name at the same time. I would much rather fix that code to distinguish that difference then do this sneaky splitting. Jarcec - Jarek Cecho On Dec. 5, 2015, 6:22 a.m., Abraham Fine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40896/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2015, 6:22 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2719 > https://issues.apache.org/jira/browse/SQOOP-2719 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Sqoop2: Ensure the GenericJDBCConnector integration tests work against MySQL, > PostgreSQL, and Oracle > > > Diffs > ----- > > > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java > f30d587 > > common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java > 393904f > > common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java > b5f3104 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java > edb2754 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java > fa26c14 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartition.java > 65400ef > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java > 2a42ed4 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java > 3b52128 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java > 3a767ab > docs/src/site/sphinx/user/connectors/Connector-GenericJDBC.rst 347547d > test/src/main/java/org/apache/sqoop/test/data/Cities.java fbbd7ef > test/src/main/java/org/apache/sqoop/test/data/DataSet.java 5e109b1 > test/src/main/java/org/apache/sqoop/test/data/ShortStories.java b84339e > test/src/main/java/org/apache/sqoop/test/data/UbuntuReleases.java f8aeb38 > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java > 4c5d3a8 > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > c843448 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/AppendModeTest.java > 8c65898 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/FromHDFSToHDFSTest.java > c39c8d6 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/HdfsIncrementalReadTest.java > e6f6e0d > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/InformalJobNameExecuteTest.java > 411b07e > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java > 1790f96 > > test/src/test/java/org/apache/sqoop/integration/connector/hive/FromRDBMSToKiteHiveTest.java > 0e46bf3 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java > 5053b56 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java > 25cdb68 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java > 686572a > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java > 38ebb74 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java > 72728fe > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java > 68dc65e > > test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromRDBMSToKafkaTest.java > 6e78a13 > > test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java > 7b2aced > > test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java > 6228b0d > > test/src/test/java/org/apache/sqoop/integration/server/ShowJobInOrderTest.java > cbf1e90 > > test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java > 9e682bc > > Diff: https://reviews.apache.org/r/40896/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Abraham Fine > >
