> On Dec. 5, 2015, 2:38 p.m., Jarek Cecho wrote: > > It seems that we have a lot of various fixes inside one patch. I hesitate > > to push this as a single change as we will loose track of why exactly we > > did those changes. Would you mind splitting each individual fix to it's own > > JIRA describing what is the problem and hence why we need to fix it? > > Abraham Fine wrote: > my concern with splitting this into a bunch of seperate patches is that > many of these changes are interdependent in nonobvious ways (due to database > idiosynchracies). I figured that it would be easier to merge it in together > so we can have a baseline for working across multiple databases. if you feel > strongly about it, i can change it.
I would like to move things that make sense aside and properly document what and why we're fixing (e.g. have separate JIRA with proper description). My concern is that year from know we won't remember why those fixes were made (which DB and on what version behaves "differently") and thus we will be likely to include regressions. I know that we should test all the databases and all their versions, but experience from Sqoop 1 told us that it's not always that easy :) - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40896/#review109086 ----------------------------------------------------------- On Dec. 8, 2015, 9:52 p.m., Abraham Fine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40896/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2015, 9:52 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2719 > https://issues.apache.org/jira/browse/SQOOP-2719 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Sqoop2: Ensure the GenericJDBCConnector integration tests work against MySQL, > PostgreSQL, and Oracle > > > Diffs > ----- > > > common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java > 0da7ea8 > > common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java > f30d587 > > common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java > 393904f > > common-test/src/main/java/org/apache/sqoop/common/test/db/OracleProvider.java > b5f3104 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java > ff33a4b > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java > edb2754 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java > fa26c14 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartition.java > 65400ef > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcPartitioner.java > 2a42ed4 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java > 3b52128 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java > 3a767ab > docs/src/site/sphinx/user/connectors/Connector-GenericJDBC.rst 347547d > test/src/main/java/org/apache/sqoop/test/data/Cities.java fbbd7ef > test/src/main/java/org/apache/sqoop/test/data/DataSet.java 5e109b1 > test/src/main/java/org/apache/sqoop/test/data/ShortStories.java b84339e > test/src/main/java/org/apache/sqoop/test/data/UbuntuReleases.java f8aeb38 > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java > c1f355f > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > c843448 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/AppendModeTest.java > 8c65898 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/FromHDFSToHDFSTest.java > c39c8d6 > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/HdfsIncrementalReadTest.java > e6f6e0d > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/InformalJobNameExecuteTest.java > 411b07e > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java > 1790f96 > > test/src/test/java/org/apache/sqoop/integration/connector/hive/FromRDBMSToKiteHiveTest.java > e964422 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java > 5053b56 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java > 25cdb68 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java > 686572a > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java > 38ebb74 > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java > 72728fe > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java > 68dc65e > > test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromRDBMSToKafkaTest.java > 4ecb018 > > test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java > 7b2aced > > test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java > 8b57d75 > > test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java > c2709a7 > > Diff: https://reviews.apache.org/r/40896/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Abraham Fine > >
