[ 
https://issues.apache.org/jira/browse/SQOOP-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050902#comment-15050902
 ] 

Sqoop QA bot commented on SQOOP-2725:
-------------------------------------

Testing file 
[SQOOP-2725.patch|https://issues.apache.org/jira/secure/attachment/12776683/SQOOP-2725.patch]
 against branch sqoop2 took 1:12:11.952299.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1640 tests)
{color:orange}WARNING:{color} Test coverage has decreased 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1982/artifact/patch-process/cobertura_report.txt])
* Package {{connector/connector-hdfs}}: Can't compare test coverage as base is 
missing.
* Package {{connector/connector-sftp}}: Can't compare test coverage as base is 
missing.
* Package {{connector/connector-sdk}}: Can't compare test coverage as base is 
missing.
* Package {{connector/connector-generic-jdbc}}: Can't compare test coverage as 
base is missing.
* Package {{server}}: Can't compare test coverage as base is missing.
* Package {{security}}: Can't compare test coverage as base is missing.
* Package {{execution/mapreduce}}: Can't compare test coverage as base is 
missing.
* Package {{core}}: Can't compare test coverage as base is missing.
* Package {{common-test}}: Can't compare test coverage as base is missing.
* Package {{shell}}: Can't compare test coverage as base is missing.
* Package {{client}}: Can't compare test coverage as base is missing.
* Package {{tools}}: Can't compare test coverage as base is missing.
* Package {{test}}: Can't compare test coverage as base is missing.
* Package {{repository/repository-postgresql}}: Can't compare test coverage as 
base is missing.
* Package {{repository/repository-mysql}}: Can't compare test coverage as base 
is missing.
* Package {{repository/repository-common}}: Can't compare test coverage as base 
is missing.
* Package {{repository/repository-derby}}: Can't compare test coverage as base 
is missing.


{color:orange}WARNING:{color} New findbugs warnings 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1982/artifact/patch-process/findbugs_report.txt])
* Package {{submission/mapreduce}}: Can't compare classes as base is missing.
* Package {{common}}: Can't compare classes as base is missing.
* Package {{connector/connector-kafka}}: Can't compare classes as base is 
missing.
* Package {{connector/connector-ftp}}: Can't compare classes as base is missing.
* Package {{connector/connector-kite}}: Can't compare classes as base is 
missing.
* Package {{connector/connector-oracle-jdbc}}: Can't compare classes as base is 
missing.
* Package {{connector/connector-hdfs}}: Can't compare classes as base is 
missing.
* Package {{connector/connector-sftp}}: Can't compare classes as base is 
missing.
* Package {{connector/connector-sdk}}: Can't compare classes as base is missing.
* Package {{connector/connector-generic-jdbc}}: Can't compare classes as base 
is missing.
* Package {{server}}: Can't compare classes as base is missing.
* Package {{security}}: Can't compare classes as base is missing.
* Package {{execution/mapreduce}}: Can't compare classes as base is missing.
* Package {{core}}: Can't compare classes as base is missing.
* Package {{common-test}}: Can't compare classes as base is missing.
* Package {{shell}}: Can't compare classes as base is missing.
* Package {{client}}: Can't compare classes as base is missing.
* Package {{tools}}: Can't compare classes as base is missing.
* Package {{test}}: Can't compare classes as base is missing.
* Package {{repository/repository-postgresql}}: Can't compare classes as base 
is missing.
* Package {{repository/repository-mysql}}: Can't compare classes as base is 
missing.
* Package {{repository/repository-common}}: Can't compare classes as base is 
missing.
* Package {{repository/repository-derby}}: Can't compare classes as base is 
missing.


{color:green}SUCCESS:{color} All integration tests passed (executed 145 tests)

Console output is available 
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1982/console].

This message is automatically generated.

> Sqoop2: Integration Tests: Prefer using Timestamp types and 
> PreparedStatements for inserting rows into test databases
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-2725
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2725
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.6
>            Reporter: Abraham Fine
>            Assignee: Abraham Fine
>         Attachments: SQOOP-2725.patch
>
>
> MySQL, PostgreSQL, and Oracle have slightly different syntaxes for inserting 
> dates that PreparedStatements deal with for us. We should use them when 
> inserting our test data.
> In addition, each database seems to have different ways of printing dates, 
> timestamps seemed to provide the greatest amount of consistency. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to