[ 
https://issues.apache.org/jira/browse/SQOOP-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15057234#comment-15057234
 ] 

Sqoop QA bot commented on SQOOP-2725:
-------------------------------------

Testing file 
[SQOOP-2725.patch|https://issues.apache.org/jira/secure/attachment/12777642/SQOOP-2725.patch]
 against branch sqoop2 took 0:58:10.543421.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1638 tests)
{color:orange}WARNING:{color} Test coverage has decreased 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1996/artifact/patch-process/cobertura_report.txt])
* Package {{connector/connector-generic-jdbc}} has lower test coverage: Line 
coverage decreased by 1% (from 79% to 78%), Branch coverage decreased by 2% 
(from 56% to 54%)


{color:green}SUCCESS:{color} No new findbugs warnings 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1996/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 145 tests)

Console output is available 
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1996/console].

This message is automatically generated.

> Sqoop2: Integration Tests: Prefer using Timestamp types and 
> PreparedStatements for inserting rows into test databases
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-2725
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2725
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.99.6
>            Reporter: Abraham Fine
>            Assignee: Abraham Fine
>         Attachments: SQOOP-2725.patch
>
>
> MySQL, PostgreSQL, and Oracle have slightly different syntaxes for inserting 
> dates that PreparedStatements deal with for us. We should use them when 
> inserting our test data.
> In addition, each database seems to have different ways of printing dates, 
> timestamps seemed to provide the greatest amount of consistency. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to