-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44317/#review122924
-----------------------------------------------------------
Overall, I'm fine with the patch as discussed on the JIRA. I have just one
comment - it seems that current version of patch breaks some other tests:
Testcase: testNonstandardCharactersInColumnName took 0.964 sec
FAILED
expected:<AVRO[]1> but was:<AVRO[_]1>
junit.framework.ComparisonFailure: expected:<AVRO[]1> but was:<AVRO[_]1>
at com.cloudera.sqoop.TestAvroImport.checkField(TestAvroImport.java:277)
at
com.cloudera.sqoop.TestAvroImport.testNonstandardCharactersInColumnName(TestAvroImport.java:226)
Could you take a look?
- Jarek Cecho
On March 3, 2016, 7:15 a.m., vishnu s nair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44317/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 7:15 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2561
> https://issues.apache.org/jira/browse/SQOOP-2561
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Special Character removal from Column name as avro data results in
> duplicate column and fails the import
>
> Solution: Instead of removing the special character, replace it with
> underscore
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/avro/AvroUtil.java 90cc9d0
> src/test/com/cloudera/sqoop/TestAvroImport.java 00d7a95
>
> Diff: https://reviews.apache.org/r/44317/diff/
>
>
> Testing
> -------
>
> Test case for the same is exceuted successfully.
>
>
> Thanks,
>
> vishnu s nair
>
>
