----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44317/#review124595 -----------------------------------------------------------
One formatting comment and otherwise +1. src/test/com/cloudera/sqoop/TestAvroImport.java (lines 252 - 274) <https://reviews.apache.org/r/44317/#comment187205> The intendation is completely off and there is a whitespace character. - Jarek Cecho On March 11, 2016, 4:49 a.m., vishnu s nair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44317/ > ----------------------------------------------------------- > > (Updated March 11, 2016, 4:49 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2561 > https://issues.apache.org/jira/browse/SQOOP-2561 > > > Repository: sqoop-trunk > > > Description > ------- > > Special Character removal from Column name as avro data results in > duplicate column and fails the import > > Solution: Instead of removing the special character, replace it with > underscore > > > Diffs > ----- > > src/java/org/apache/sqoop/avro/AvroUtil.java 90cc9d0 > src/test/com/cloudera/sqoop/TestAvroImport.java 00d7a95 > > Diff: https://reviews.apache.org/r/44317/diff/ > > > Testing > ------- > > Test case for the same is exceuted successfully. > > > File Attachments > ---------------- > > D:\Users\vsnair\workspace\sqoop_trunk > > https://reviews.apache.org/media/uploaded/files/2016/03/11/61b2bb9e-47f9-4e9a-9a94-fe8fd03b02e7__0001-SQOOP-2561.patch > > > Thanks, > > vishnu s nair > >
