Github user JoeriHermans commented on the pull request:
https://github.com/apache/sqoop/pull/18#issuecomment-208796233
@stanleyxu2005 Why would you check if data has valid length? The original
code also crashes if an empty string is specified, so I didn't bother with
checking for validity. Furthermore, I don't think it is necessary to create a
wrapper for this method.
I also wanted to ask why in
https://github.com/apache/sqoop/commit/1dd50cfb2ae327b0df8393dd96d1adb86bb2f65f
candidate.replaceAll("\\W+", "") has been replaced with
candidate.replaceAll("\\W+", "_")? This change makes our code a bit slower, and
does not add any value from my point of view. Of course, if this is done with a
particular reason, I will commit the change.
Kind regards,
Joeri
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
