Github user JoeriHermans commented on the pull request:
https://github.com/apache/sqoop/pull/18#issuecomment-208859666
@stanleyxu2005 The main difference in my implementation is that I only have
to do a single copy. StringBuilders are inefficient, char arrays are a lot
faster since everything is pre-allocated already. Furthermore, the overhead
over constantly allocating a new object, and the fact that internally the
StringBuilder will do some copying as well, make this an inefficient approach.
For example, I implemented your approach and instead of a 500% improvement
with our method, I have a 230% increase in performance with the StringBuilder
approach. So the char-array is definitely a lot faster, and this is what it is
all about, since this is a very prominent function on the stack.
Kind regards,
Joeri
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
