----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47917/#review135103 -----------------------------------------------------------
Fix it, then Ship it! client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java (line 214) <https://reviews.apache.org/r/47917/#comment200113> what do you think about using assertFalse instead of assertTrue(!...)? - Abraham Fine On May 26, 2016, 10:40 p.m., Erzsebet Szilagyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47917/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 10:40 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1531 > https://issues.apache.org/jira/browse/SQOOP-1531 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Added functions to shell and client to support getting connectors listed by > direction > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/SqoopClient.java 1cf549e > client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java adf4eb5 > shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java > c90fe94 > shell/src/main/java/org/apache/sqoop/shell/core/Constants.java a5f5d4d > shell/src/main/resources/shell-resource.properties 2c94c58 > shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java 49affa3 > > Diff: https://reviews.apache.org/r/47917/diff/ > > > Testing > ------- > > Added unit tests. > Both unit and integration tests run successfully. > > > Thanks, > > Erzsebet Szilagyi > >
