> On May 27, 2016, 12:51 a.m., Abraham Fine wrote: > > client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java, line 214 > > <https://reviews.apache.org/r/47917/diff/1-3/?file=1395804#file1395804line214> > > > > what do you think about using assertFalse instead of assertTrue(!...)?
- assertFalse requires another import in this file; - personally i feel like using assertTrue in these lines gives a more consistent picture than having both assertFalse and assertTrue. - Erzsebet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47917/#review135103 ----------------------------------------------------------- On May 27, 2016, 12:40 a.m., Erzsebet Szilagyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47917/ > ----------------------------------------------------------- > > (Updated May 27, 2016, 12:40 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1531 > https://issues.apache.org/jira/browse/SQOOP-1531 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Added functions to shell and client to support getting connectors listed by > direction > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/SqoopClient.java 1cf549e > client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java adf4eb5 > shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java > c90fe94 > shell/src/main/java/org/apache/sqoop/shell/core/Constants.java a5f5d4d > shell/src/main/resources/shell-resource.properties 2c94c58 > shell/src/test/java/org/apache/sqoop/shell/TestShowCommand.java 49affa3 > > Diff: https://reviews.apache.org/r/47917/diff/ > > > Testing > ------- > > Added unit tests. > Both unit and integration tests run successfully. > > > Thanks, > > Erzsebet Szilagyi > >
