[ 
https://issues.apache.org/jira/browse/SQOOP-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306335#comment-15306335
 ] 

Erzsebet Szilagyi commented on SQOOP-2937:
------------------------------------------

I believe that the smaller the change per reviews, the easier it is to 
effectively review them - hence I would recommend breaking it into as smallest 
meaningful patches as possible.

In this case, I'd probably separate the tape support into a different review 
and even create a Jira subtask as well (keeping this ticket as the parent).
As you already have these patches, my guess is that there isn't a practical 
separation for the GDG and sequential support, but otherwise I'd check if there 
is a both meaningful and practical separation for them.

I also welcome all input regarding this.

> Sqoop mainframe module does not support sequential data sets, GDG, or data 
> sets on tape
> ---------------------------------------------------------------------------------------
>
>                 Key: SQOOP-2937
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2937
>             Project: Sqoop
>          Issue Type: Improvement
>          Components: connectors
>    Affects Versions: 1.4.6
>         Environment: mainframe
>            Reporter: Chris
>            Priority: Minor
>              Labels: patch
>             Fix For: 1.4.7
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> The mainframe module (SQOOP-1272) currently supports partitioned data sets.
> I propose adding the following improvements:-
> - sequential data set support
> - GDG data set support
> - data sets stored on tape.
> I propose the following parameters to be added:-
> 1. --datasettype <p|s|g>  (p = partitioned data set, s = sequential, g = GDG)
> 2. --tape <true|false> (true = data set is on tape, false = data set is not 
> on tape)
> Let me know if this should be all in one issue or separate issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to