----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48077/#review135694 -----------------------------------------------------------
src/docs/user/hcatalog.txt (line 38) <https://reviews.apache.org/r/48077/#comment200721> Minor nit: typo? src/docs/user/hcatalog.txt (line 334) <https://reviews.apache.org/r/48077/#comment200722> Minor nit: typo '{' -> '['? src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatExportHelper.java (line 277) <https://reviews.apache.org/r/48077/#comment200728> missing break statement? src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatExportHelper.java (line 453) <https://reviews.apache.org/r/48077/#comment200734> Can value be null here? src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatImportHelper.java (line 354) <https://reviews.apache.org/r/48077/#comment200747> BIGINT is changed to LONG. Can category be BIGINT instead of long? src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatImportHelper.java (line 468) <https://reviews.apache.org/r/48077/#comment200741> Can this cause NPE? If so shoudl it be handled as regular Exception, I see that you are catching exception and loggign error. src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java (line 473) <https://reviews.apache.org/r/48077/#comment200754> Can you help me understand why size > 1 and not zero? - Sowmya Ramesh On May 31, 2016, 2:55 p.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48077/ > ----------------------------------------------------------- > > (Updated May 31, 2016, 2:55 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Bugs: SQOOP-2935 > https://issues.apache.org/jira/browse/SQOOP-2935 > > > Repository: sqoop-trunk > > > Description > ------- > > Support for importing and exporting to columns of Hive complex data type > using the HCatalog integration path. Documentation added to the hcatalog > page on the usage. > > > Diffs > ----- > > src/docs/user/hcatalog.txt 2ae1d54 > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatExportHelper.java 57a90b0 > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatImportHelper.java aba2458 > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java ebe7209 > src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 8aa0725 > src/test/org/apache/sqoop/hcat/HCatalogImportTest.java 67b7a78 > src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java f4b1ea9 > > Diff: https://reviews.apache.org/r/48077/diff/ > > > Testing > ------- > > Added unit tests for complex types for both import and export > > > Thanks, > > Venkat Ranganathan > >
