----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48077/#review135718 -----------------------------------------------------------
src/docs/user/hcatalog.txt (line 38) <https://reviews.apache.org/r/48077/#comment200768> Good point - will remove src/docs/user/hcatalog.txt (line 334) <https://reviews.apache.org/r/48077/#comment200769> No, Maps are represented with '{' key : val '}' src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatExportHelper.java (line 277) <https://reviews.apache.org/r/48077/#comment200774> it does not matter as the value == null will result in an exception later. But will add src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatImportHelper.java (line 354) <https://reviews.apache.org/r/48077/#comment200777> HCatFieldType was used earlier and now we use Primitive cataegory from Hive for handling complex types and it differs. Both LONG and BIGINT are the same representation of the types. src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java (line 473) <https://reviews.apache.org/r/48077/#comment200778> Thanks for pointing it out. It should be > 0. For arrays, the elementschema is the only member and for maps also the valueschema will be one. Thanks Sowmya for a quick review. will update the patch. There were also a few trailing blanks that I will remove. - Venkat Ranganathan On May 31, 2016, 7:55 a.m., Venkat Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48077/ > ----------------------------------------------------------- > > (Updated May 31, 2016, 7:55 a.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Bugs: SQOOP-2935 > https://issues.apache.org/jira/browse/SQOOP-2935 > > > Repository: sqoop-trunk > > > Description > ------- > > Support for importing and exporting to columns of Hive complex data type > using the HCatalog integration path. Documentation added to the hcatalog > page on the usage. > > > Diffs > ----- > > src/docs/user/hcatalog.txt 2ae1d54 > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatExportHelper.java 57a90b0 > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatImportHelper.java aba2458 > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java ebe7209 > src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 8aa0725 > src/test/org/apache/sqoop/hcat/HCatalogImportTest.java 67b7a78 > src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java f4b1ea9 > > Diff: https://reviews.apache.org/r/48077/diff/ > > > Testing > ------- > > Added unit tests for complex types for both import and export > > > Thanks, > > Venkat Ranganathan > >
