----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53134/#review153692 -----------------------------------------------------------
src/java/com/cloudera/sqoop/SqoopOptions.java (line 23) <https://reviews.apache.org/r/53134/#comment223111> We usually avoid wildcard imports, can you please organize it? src/test/org/apache/sqoop/tool/ImportToolValidateOptionsTest.java (line 9) <https://reviews.apache.org/r/53134/#comment223112> We usually avoid wildcard imports, can you please organize it? src/test/org/apache/sqoop/tool/ImportToolValidateOptionsTest.java (line 88) <https://reviews.apache.org/r/53134/#comment223113> The new test cases look good only the names should be fixed. E.g. testValidationSucceedWithHBaseImportAndAsSequenceFiles should be testValidationFailsWithHBaseImportAndAsSequenceFilebecause the test throws an exception. - Szabolcs Vasas On Oct. 24, 2016, 2:03 p.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53134/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2016, 2:03 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3034 > https://issues.apache.org/jira/browse/SQOOP-3034 > > > Repository: sqoop-trunk > > > Description > ------- > > HBase import should fail fast if using anything other than as-textfile as > those are ignored in the current implementation, however, the user is not > informed about it and the HBase import performs silently as a textfile. > > > Diffs > ----- > > src/java/com/cloudera/sqoop/SqoopOptions.java > f4ababeada9af866e65b5f11124451d39a81e6ff > src/java/org/apache/sqoop/tool/BaseSqoopTool.java > 13a9697b2d94e3846f86e1b605cfff3d01dd9347 > src/test/org/apache/sqoop/tool/ImportToolValidateOptionsTest.java > 503a86340f5ae33c8eb0a27b8450b2af0a342db9 > > Diff: https://reviews.apache.org/r/53134/diff/ > > > Testing > ------- > > Test cases have been added for option validation check. > > > Thanks, > > Boglarka Egyed > >
