----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53134/#review153699 -----------------------------------------------------------
H src/java/com/cloudera/sqoop/SqoopOptions.java (lines 46 - 59) <https://reviews.apache.org/r/53134/#comment223117> Hi, This "arg" property does not look very helpful/expressive here. Could you please rename it like "formatName" or something similar? src/java/com/cloudera/sqoop/SqoopOptions.java (lines 46 - 49) <https://reviews.apache.org/r/53134/#comment223121> I'm a bit concerned here. Do we really want to notify the user with the name of the argument instead with the name of the format? Could you please highlight me the pros? src/test/org/apache/sqoop/tool/ImportToolValidateOptionsTest.java (lines 91 - 144) <https://reviews.apache.org/r/53134/#comment223122> Could you please squash these for test cases into "one" and instead use the DDT capabilities of JUnit to solve the parametrization on that level? Hi Bogi, I think introducing this functionality totally make sense, the users must be aware about this limitation, and it most not happen silently Sqoop does something very different. Although I've found a few places where you could improve this changeset. Could you please check and fix them? Thanks, Maugli - Attila Szabo On Oct. 24, 2016, 3:49 p.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53134/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2016, 3:49 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3034 > https://issues.apache.org/jira/browse/SQOOP-3034 > > > Repository: sqoop-trunk > > > Description > ------- > > HBase import should fail fast if using anything other than as-textfile as > those are ignored in the current implementation, however, the user is not > informed about it and the HBase import performs silently as a textfile. > > > Diffs > ----- > > src/java/com/cloudera/sqoop/SqoopOptions.java > f4ababeada9af866e65b5f11124451d39a81e6ff > src/java/org/apache/sqoop/tool/BaseSqoopTool.java > 13a9697b2d94e3846f86e1b605cfff3d01dd9347 > src/test/org/apache/sqoop/tool/ImportToolValidateOptionsTest.java > 503a86340f5ae33c8eb0a27b8450b2af0a342db9 > > Diff: https://reviews.apache.org/r/53134/diff/ > > > Testing > ------- > > Test cases have been added for option validation check. > > > Thanks, > > Boglarka Egyed > >
