On Jan. 2, 2017, 2:55 p.m., Frédéric Escandell wrote:
> > I'm also curious if you've considered adding schema support at a higher 
> > level, e.g. Import instead of Direct Import or even just for Netezza in 
> > general, as schemas can be used for exports as well?
> > 
> > Have you considered adding some tests? I understand that we currently don't 
> > have tests for Netezza direct import, but there is a 
> > DirectNetezzaExportManualTest for direct export and also 
> > NetezzaImportManualTest for testing import.
> > We should always strive for increasing testing coverage.
> > 
> > Thank you,
> > Liz

+1 for considering to add the schema support at a higher level.


- Boglarka


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55079/#review160323
-----------------------------------------------------------


On Jan. 1, 2017, 8:33 p.m., Frédéric Escandell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55079/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2017, 8:33 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> SQOOP-3096
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/manager/DirectNetezzaManager.java af15824 
>   
> src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java
>  2efea53 
> 
> Diff: https://reviews.apache.org/r/55079/diff/
> 
> 
> Testing
> -------
> 
> Tested with a schema included in Netezza database (adding -- --schema <schema 
> name>) to the sqoop import command line
> 
> 
> Thanks,
> 
> Frédéric Escandell
> 
>

Reply via email to