> On jan. 2, 2017, 2:55 après-midi, Erzsebet Szilagyi wrote: > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java, > > line 83 > > <https://reviews.apache.org/r/55079/diff/1/?file=1593057#file1593057line83> > > > > You have implemented a new escaping mechanism escapeTableName. Are you > > sure escaping is not needed here too?
Before my change the table name wasn't escaped here. The adding of the schema don't force us to add the escaping mechanism. The escaping meachnism is not mandatory for Netezza request. - Frédéric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55079/#review160323 ----------------------------------------------------------- On jan. 1, 2017, 8:33 après-midi, Frédéric Escandell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55079/ > ----------------------------------------------------------- > > (Updated jan. 1, 2017, 8:33 après-midi) > > > Review request for Sqoop. > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-3096 > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/DirectNetezzaManager.java af15824 > > src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java > 2efea53 > > Diff: https://reviews.apache.org/r/55079/diff/ > > > Testing > ------- > > Tested with a schema included in Netezza database (adding -- --schema <schema > name>) to the sqoop import command line > > > Thanks, > > Frédéric Escandell > >
