> On March 20, 2017, 8:18 a.m., Boglarka Egyed wrote:
> > Hi Eric,
> > 
> > Thanks for the corrections.
> > 
> > I ran 'ant clean test' with your patch and TestHiveImport failed for me so 
> > please review your changes there.
> > 
> > Besides that, I had some minor findings related to naming conventions.
> > 
> > Thanks,
> > Bogi

UPDATE: 'ant clean test' ran successfully with the new patch (adding the 
testdata/hive/scripts/decimalImport.q file).


- Boglarka


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57551/#review169389
-----------------------------------------------------------


On March 20, 2017, 8:13 a.m., Eric Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57551/
> -----------------------------------------------------------
> 
> (Updated March 20, 2017, 8:13 a.m.)
> 
> 
> Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Currently Sqoop converts DECIMAL from RDMS into DOUBLE in Hive, which is not 
> correct as user will lose precisions. Since Hive supports DECIMAL long ago, 
> we should support DECIMAL to DECIMAL conversion from Sqoop to Hive.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/hive/HiveTypes.java ad00535 
>   src/java/org/apache/sqoop/hive/TableDefWriter.java 32fcca3 
>   src/test/com/cloudera/sqoop/hive/TestHiveImport.java 1d67a2d 
>   src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java 4db629f 
>   testdata/hive/scripts/decimalImport.q PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57551/diff/3/
> 
> 
> Testing
> -------
> 
> Test case + maunaul test
> 
> 
> Thanks,
> 
> Eric Lin
> 
>

Reply via email to