> On April 20, 2017, 1:08 p.m., Liz Szilagyi wrote: > > Hi Eric, > > Looks like you have addressed all previous concerns, yet they remain open > > issues - are you planning to do more changes to further address these > > questions? > > Thanks, > > Liz
Hi Liz, thanks for your update. I thought I want to wait for Attila to provide more inputs before I "Fix" them. But looks like I need to do it on my side so I have done so. Let me know if there are more actions need to take here. Thanks again. - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57551/#review172478 ----------------------------------------------------------- On March 28, 2017, 4:35 a.m., Eric Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57551/ > ----------------------------------------------------------- > > (Updated March 28, 2017, 4:35 a.m.) > > > Review request for Sqoop, Attila Szabo and Szabolcs Vasas. > > > Repository: sqoop-trunk > > > Description > ------- > > Currently Sqoop converts DECIMAL from RDMS into DOUBLE in Hive, which is not > correct as user will lose precisions. Since Hive supports DECIMAL long ago, > we should support DECIMAL to DECIMAL conversion from Sqoop to Hive. > > > Diffs > ----- > > src/java/org/apache/sqoop/hive/HiveTypes.java ad00535 > src/java/org/apache/sqoop/hive/TableDefWriter.java 32fcca3 > src/test/com/cloudera/sqoop/hive/TestHiveImport.java 33e0cc4 > src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java dbf0dde > testdata/hive/scripts/decimalImport.q PRE-CREATION > > > Diff: https://reviews.apache.org/r/57551/diff/5/ > > > Testing > ------- > > Test case + maunaul test > > > Thanks, > > Eric Lin > >