----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60090/#review177993 -----------------------------------------------------------
Hi Szabi, Thanks for the fix, however, TestExportUsingProcedure unit tests fails for me with your patch. Could you please review your changes? Thanks, Bogi src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java Line 308 (original), 310 (patched) <https://reviews.apache.org/r/60090/#comment251726> Some extra indentation happened here, could you please revert it? - Boglarka Egyed On June 14, 2017, 3:48 p.m., Szabolcs Vasas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60090/ > ----------------------------------------------------------- > > (Updated June 14, 2017, 3:48 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3198 > https://issues.apache.org/jira/browse/SQOOP-3198 > > > Repository: sqoop-trunk > > > Description > ------- > > I modified the data type used in > com.cloudera.sqoop.TestExport#testLessColumnsInFileThanInTable since it does > not matter from the test's perspective but in OracleExportTest the date > formatting is a bit different and it caused problems. > > > Diffs > ----- > > src/test/com/cloudera/sqoop/TestExport.java > 8b468c82d8cc2cdd74f12492cee2aece6152adf9 > src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java > ec7b84a6b3f8b9a5b869e9bd3fa8e9cc4c404313 > > > Diff: https://reviews.apache.org/r/60090/diff/2/ > > > Testing > ------- > > Ran third party test cases. > > > Thanks, > > Szabolcs Vasas > >
