> On June 15, 2017, 11:44 a.m., Boglarka Egyed wrote: > > Hi Szabi, > > > > Thanks for the fix, however, TestExportUsingProcedure unit tests fails for > > me with your patch. > > > > Could you please review your changes? > > > > Thanks, > > Bogi
Hi Bogi, Thank you for reviewing, I have fixed the failing test case. - Szabolcs ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60090/#review177993 ----------------------------------------------------------- On June 15, 2017, 12:43 p.m., Szabolcs Vasas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60090/ > ----------------------------------------------------------- > > (Updated June 15, 2017, 12:43 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3198 > https://issues.apache.org/jira/browse/SQOOP-3198 > > > Repository: sqoop-trunk > > > Description > ------- > > I modified the data type used in > com.cloudera.sqoop.TestExport#testLessColumnsInFileThanInTable since it does > not matter from the test's perspective but in OracleExportTest the date > formatting is a bit different and it caused problems. > > > Diffs > ----- > > src/test/com/cloudera/sqoop/TestExport.java > 8b468c82d8cc2cdd74f12492cee2aece6152adf9 > src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java > ec7b84a6b3f8b9a5b869e9bd3fa8e9cc4c404313 > src/test/org/apache/sqoop/TestExportUsingProcedure.java > 68e79f1252a1c0350f15c4f161b303ad412fb15b > > > Diff: https://reviews.apache.org/r/60090/diff/3/ > > > Testing > ------- > > Ran third party test cases. > > > Thanks, > > Szabolcs Vasas > >
