----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/#review186571 -----------------------------------------------------------
Hi Chris, Thank you for your patch! Generally it looks good to me however I am not that familiar with the mainframe world, can you please give us a bit more context about the datasets? As far as I understand from the code we have different data set types (e.g. sequential, partitioned) but is GDG and tape orthogonal properties to these? I have seen that whitespace changes were introduced in many lines (they are marked with arrows and red bars in the review) can you please fix those as they make the review much harder? Regards, Szabolcs src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java Line 68 (original), 68 (patched) <https://reviews.apache.org/r/62653/#comment263275> isTape is not used anymore, you can remove this line. src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java Line 83 (original), 83 (patched) <https://reviews.apache.org/r/62653/#comment263139> String values should be compared using the equals() method. src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java Lines 355 (patched) <https://reviews.apache.org/r/62653/#comment263217> I would verify here that the mockFTPClient.listFiles() is invoked since (AFAIK) in this test case we want to make sure that for partitioned datasets we use the default FTP list parsing. - Szabolcs Vasas On Sept. 28, 2017, 9:28 a.m., Chris Teoh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62653/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2017, 9:28 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3225 > https://issues.apache.org/jira/browse/SQOOP-3225 > > > Repository: sqoop-trunk > > > Description > ------- > > There were some cases where the FTP listing parser was not used for mainframe > datasets, only the default was used. This caused some datasets to not be seen > by Sqoop as the default parser couldn't find them. This patch addresses this > behaviour where it is used to parse FTP listings for sequential and gdg > datasets on disk and tape, only partitioned datasets are excluded as their > FTP listing looks very different and is handled by the default FTP listing > parser. > > > Diffs > ----- > > src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java f61b9838 > src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java d87c75df > > > Diff: https://reviews.apache.org/r/62653/diff/3/ > > > Testing > ------- > > Unit testing. > Functional testing on a real mainframe with a previous combined patch. > > > Thanks, > > Chris Teoh > >
