> On Sept. 29, 2017, 9:41 a.m., Szabolcs Vasas wrote: > > Hi Chris, > > > > Thank you for improving the patch and the description of the datasets! > > I have left few more comments and I can see that there are still some > > whitespace changes (they are shown by ReviewBoard as well) can you please > > fix those as well? > > > > I have run the unit tests and I can see that > > TestMainframeDatasetInputFormat is failing. Can you please check it? > > > > Thanks, > > Szabolcs
Thanks for picking this up. I have updated the code so the unit test passes. My later diffs don't appear to have the red bars, if I have missed any, please point them out. - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62653/#review186652 ----------------------------------------------------------- On Oct. 2, 2017, 11:12 p.m., Chris Teoh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62653/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2017, 11:12 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3225 > https://issues.apache.org/jira/browse/SQOOP-3225 > > > Repository: sqoop-trunk > > > Description > ------- > > There were some cases where the FTP listing parser was not used for mainframe > datasets, only the default was used. This caused some datasets to not be seen > by Sqoop as the default parser couldn't find them. This patch addresses this > behaviour where it is used to parse FTP listings for sequential and gdg > datasets on disk and tape, only partitioned datasets are excluded as their > FTP listing looks very different and is handled by the default FTP listing > parser. > > > Diffs > ----- > > src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java f61b9838 > src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java d87c75df > > > Diff: https://reviews.apache.org/r/62653/diff/5/ > > > Testing > ------- > > Unit testing. > Functional testing on a real mainframe with a previous combined patch. > > > Thanks, > > Chris Teoh > >
