Github user szvasas commented on a diff in the pull request:
https://github.com/apache/sqoop/pull/41#discussion_r158502479
--- Diff: src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java
---
@@ -61,6 +62,9 @@ private void writeObject(Object o) throws IOException {
if (o instanceof Text) {
Text to = (Text) o;
out.write(to.getBytes(), 0, to.getLength());
+ } else if (o instanceof BytesWritable) {
--- End diff --
I think it would be a good idea to keep the BinaryKeyOutputFormat because
we change the behavior of RawKeyTextOutputFormat now which may lead to issues
in other connectors and its name suggests that it handles text and not binary.
You can use a technique to elimiate the code duplication similar I used in
MainframeDatasetBinaryImportMapper.
---
