Github user szvasas commented on a diff in the pull request:
https://github.com/apache/sqoop/pull/41#discussion_r158502339
--- Diff: src/java/org/apache/sqoop/SqoopOptions.java ---
@@ -308,7 +308,9 @@ public String toString() {
// Indicates if the data set is on tape to use different FTP parser
@StoredAsProperty("mainframe.input.dataset.tape")
private String mainframeInputDatasetTape;
-
+ // Indicates if binary or ascii FTP transfer mode should be used
+ @StoredAsProperty("mainframe.ftp.transfermode")
+ private String mainframeFtpTransferMode;
--- End diff --
So my idea is to add a new field to
com.cloudera.sqoop.SqoopOptions.FileLayout, let's say BinaryFile which would
only be supported for mainframe imports (we should add validator to check this)
and I would use this new field instead of introducing the new
mainframeFtpTransferMode Sqoop option. This would not make the Sqoop interface
more complex and would let us reuse already existing concepts. What do you
think?
---
