[
https://issues.apache.org/jira/browse/SQOOP-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405022#comment-16405022
]
ASF GitHub Bot commented on SQOOP-3224:
---------------------------------------
Github user fszabo2 commented on a diff in the pull request:
https://github.com/apache/sqoop/pull/44#discussion_r175478607
--- Diff:
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java ---
@@ -33,4 +33,13 @@
public static final String MAINFRAME_INPUT_DATASET_TAPE =
"mainframe.input.dataset.tape";
public static final String MAINFRAME_FTP_FILE_ENTRY_PARSER_CLASSNAME =
"org.apache.sqoop.mapreduce.mainframe.MainframeFTPFileEntryParser";
+
+ public static final String MAINFRAME_FTP_TRANSFER_MODE =
"mainframe.ftp.transfermode";
+
+ public static final String MAINFRAME_FTP_TRANSFER_MODE_ASCII = "ascii";
+
+ public static final String MAINFRAME_FTP_TRANSFER_MODE_BINARY = "binary";
+
+ // this is the buffer size used when doing binary ftp transfers from
mainframe
+ public static final Integer MAINFRAME_FTP_TRANSFER_BINARY_BUFFER = 32760;
--- End diff --
Is this value always a good choice? I would make it configurable (if it
isn't already), and use this value as default if said configuration is not
present, so the user has a choice here.
> Mainframe FTP transfer should have an option to use binary mode for transfer
> ----------------------------------------------------------------------------
>
> Key: SQOOP-3224
> URL: https://issues.apache.org/jira/browse/SQOOP-3224
> Project: Sqoop
> Issue Type: Improvement
> Reporter: Chris Teoh
> Assignee: Chris Teoh
> Priority: Minor
>
> Currently the mainframe FTP module is hard coded to use ascii transfer mode.
> Propose a mainframe module flag to be able to change modes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
