[ 
https://issues.apache.org/jira/browse/SQOOP-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495085#comment-16495085
 ] 

ASF GitHub Bot commented on SQOOP-3224:
---------------------------------------

GitHub user christeoh opened a pull request:

    https://github.com/apache/sqoop/pull/47

    SQOOP-3224: Mainframe Binary File Transfer mode

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/christeoh/sqoop 3224-5

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/sqoop/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #47
    
----
commit e450d857eb09418463d8e4a312a5acd4866436f4
Author: Chris Teoh <cteoh@...>
Date:   2018-05-23T06:00:43Z

    Fixed merge conflict

commit f0136a65da4eae8a7f61e411fca17c4ab1be5aca
Author: Chris Teoh <cteoh@...>
Date:   2018-05-23T06:01:50Z

    Refactored com.cloudera namespace to org.apache.sqoop

commit 16d9821531e55819bf6e1d35a4cca841d991344f
Author: Chris Teoh <cteoh@...>
Date:   2018-05-23T07:03:33Z

    Added --as-binary flag

commit 0f743e49ee6ed78f3363461797cca794766c6b86
Author: Chris Teoh <cteoh@...>
Date:   2017-11-15T02:36:07Z

    Moved mainframe FTP transfermode default setting to initDefaults()

commit 348ac8e66d5d44d06fffa0a0ffb0ef0ad1d1a20d
Author: Chris Teoh <cteoh@...>
Date:   2017-11-15T02:38:02Z

    Replaced import java.io.* with single class imports

commit 45346912ac8a8c0f9b34e80b9b20517e46288e0e
Author: Chris Teoh <cteoh@...>
Date:   2017-11-16T02:07:07Z

    Removed excessive logging per record to improve performance

commit 71cf80319a0d74e1d376a92bc82ad879881ade28
Author: Chris Teoh <cteoh@...>
Date:   2017-11-16T02:07:42Z

    Added comment to document why we need to add custom class for binary 
transfers

commit 57c6ece38654c5e92744b88b395f1e6e3d3eaaef
Author: Chris Teoh <cteoh@...>
Date:   2017-11-16T03:27:48Z

    Converted to use BufferedInputStream instead of InputStream

commit 49382f0272c70a99f9e2b91cbcefda274190e2bb
Author: Chris Teoh <cteoh@...>
Date:   2017-11-17T00:57:48Z

    Added unit tests for MainframeDatasetFTPRecordReader.getNextBinaryRecord

commit b4ab6218a94b28e76ea2e6670eb60489c41c4dde
Author: Chris Teoh <cteoh@...>
Date:   2017-11-17T01:19:04Z

    Updated unit tests and used helper classes

commit c10c1ef0f06b40424ac225c6bc95722d7e5f8a90
Author: Chris Teoh <cteoh@...>
Date:   2017-11-17T01:22:06Z

    Updated unit tests to use a method of org.junit.Assert

commit e03f5b70d6e9e836c7cfaad8ec433dd21d97e965
Author: Chris Teoh <cteoh@...>
Date:   2017-11-17T01:35:04Z

    Updated unit test for compilation

commit 11cb40a0a397019e9fcd9940941c4e76766f3c77
Author: Chris Teoh <cteoh@...>
Date:   2017-11-17T05:28:57Z

    Used StringUtils to do comparisons and corrected bulk imports

commit cf26972ebccc673960130dfb33b35b472e8387de
Author: Chris Teoh <cteoh@...>
Date:   2017-11-28T03:51:07Z

    Replaced star import with specific class import

commit e002e17a9231e4c1f3d8cf4fd4e5a1b3cf517c9c
Author: Chris Teoh <cteoh@...>
Date:   2017-11-28T03:52:10Z

    Refactored common functionality to another function

commit 07cfa041ddddc9b5e9e4dd4888cad1cf0ae93f28
Author: Chris Teoh <cteoh@...>
Date:   2017-11-28T03:52:30Z

    Adjusted comment

commit 32aa551a1c42732d871d1849800a512a40f7e5ed
Author: Chris Teoh <cteoh@...>
Date:   2017-11-29T04:36:44Z

    Moved tests from TestMainframeDatasetFTPRecordReader to separate class

commit 5d6c56bc46a294b97430bb22479d733b6976c4a0
Author: Chris Teoh <cteoh@...>
Date:   2017-11-29T04:37:15Z

    Adjusted class for unit test support:

commit f52e5c9f23c83318b3cd1d302abcd277167ee51c
Author: Chris Teoh <cteoh@...>
Date:   2017-11-29T04:38:43Z

    Adjusted exceptions to print full stack

commit b6ab74742c96fa616707238364001c9bf0b63baa
Author: Chris Teoh <cteoh@...>
Date:   2017-11-29T04:39:05Z

    Moved unit tests to another class

commit 6cd6f091ca2f600656f0386b99a8a28678859b2a
Author: Chris Teoh <cteoh@...>
Date:   2017-11-29T06:17:48Z

    Updated unit tests

commit 75c98768589c2095fdc8d98442baae06265e7733
Author: Chris Teoh <cteoh@...>
Date:   2017-11-29T11:27:58Z

    Tidied up unit tests

commit 96a93393bb26b186046df090af3754fa2eea18bb
Author: Chris Teoh <cteoh@...>
Date:   2017-11-29T11:43:28Z

    Updated getNextBinaryRecord logic to be simpler

commit 8ccbdbf5316e943ba0ee0ba2bfc3873fb14397c7
Author: Chris Teoh <cteoh@...>
Date:   2017-12-12T22:42:54Z

    Added license information

commit ac0f23decd760c052ebc40d358bc6cd627253517
Author: Chris Teoh <cteoh@...>
Date:   2017-10-25T10:20:07Z

    Added support for binary ftp transfers

commit 1785a0ce89fb89e06497853d517a910ac8d2b406
Author: Chris Teoh <cteoh@...>
Date:   2017-11-15T02:36:07Z

    Moved mainframe FTP transfermode default setting to initDefaults()

commit 9165090ae43381e5fc8d2b0023fd12b835aa06a3
Author: Chris Teoh <cteoh@...>
Date:   2017-11-15T02:38:02Z

    Replaced import java.io.* with single class imports

commit a9e9427d91811cd8e73d2adc1a6f19a8e1be858a
Author: Chris Teoh <cteoh@...>
Date:   2017-11-16T02:07:07Z

    Removed excessive logging per record to improve performance

commit 80ec7852e57dea2584cffc48570160c2b6bcd3bb
Author: Chris Teoh <cteoh@...>
Date:   2017-11-17T00:57:48Z

    Added unit tests for MainframeDatasetFTPRecordReader.getNextBinaryRecord

commit 6071a50fe88b4c14e9798b74d0f4b4174e83034c
Author: Chris Teoh <cteoh@...>
Date:   2017-11-17T01:19:04Z

    Updated unit tests and used helper classes

----


> Mainframe FTP transfer should have an option to use binary mode for transfer
> ----------------------------------------------------------------------------
>
>                 Key: SQOOP-3224
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3224
>             Project: Sqoop
>          Issue Type: Improvement
>            Reporter: Chris Teoh
>            Assignee: Chris Teoh
>            Priority: Minor
>
> Currently the mainframe FTP module is hard coded to use ascii transfer mode. 
> Propose a mainframe module flag to be able to change modes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to