----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66067/#review201738 -----------------------------------------------------------
Hi Anna, Thank you for fixing the HiveImportTest problem, it works fine now. I have added a few more comments, there are a few test cases failing now because of SQOOP-3309 but it is easy to fix it. However relnotes and release tasks fail on my side are they supposed to work with some extra parameters? .gitignore Lines 42 (patched) <https://reviews.apache.org/r/66067/#comment283301> When I execute a test case in IntelliJ a directory called out is created, can we add it to .gitignore? build.gradle Lines 110 (patched) <https://reviews.apache.org/r/66067/#comment283298> Since SQOOP-3309 we need another dependency here: common group: 'org.apache.hive', name: 'hive-jdbc', version: hcatalogVersion build.gradle Lines 168 (patched) <https://reviews.apache.org/r/66067/#comment283300> Does not really matter but there is a typo here: hadooop build.gradle Lines 176 (patched) <https://reviews.apache.org/r/66067/#comment283299> HiveServer2 test cases added in SQOOP-3309 need an extra JVM arg here: "-da:org.apache.hadoop.hive.thrift.HadoopThriftAuthBridge" - Szabolcs Vasas On April 23, 2018, 10:40 a.m., Anna Szonyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66067/ > ----------------------------------------------------------- > > (Updated April 23, 2018, 10:40 a.m.) > > > Review request for Sqoop. > > > Bugs: Sqoop-3052 > https://issues.apache.org/jira/browse/Sqoop-3052 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer > friendly / open > > > Diffs > ----- > > .gitignore 68cbe28731e613607c208824443d1edf256d9c8a > COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5 > build.gradle PRE-CREATION > config/checkstyle/checkstyle-java-header.txt PRE-CREATION > config/checkstyle/checkstyle-noframes.xsl PRE-CREATION > config/checkstyle/checkstyle.xml PRE-CREATION > gradle.properties PRE-CREATION > gradle/customUnixStartScript.txt PRE-CREATION > gradle/customWindowsStartScript.txt PRE-CREATION > gradle/sqoop-package.gradle PRE-CREATION > gradle/sqoop-version-gen.gradle PRE-CREATION > gradle/wrapper/gradle-wrapper.jar PRE-CREATION > gradle/wrapper/gradle-wrapper.properties PRE-CREATION > gradlew PRE-CREATION > gradlew.bat PRE-CREATION > settings.gradle PRE-CREATION > src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556 > testdata/hcatalog/conf/hive-site.xml > edac7aa9087a84b7a0c660907794adae684ae313 > > > Diff: https://reviews.apache.org/r/66067/diff/9/ > > > Testing > ------- > > ran all new tasks, except for internal maven publishing > > Notes: > - To try it out you can call ./gradlew tasks --all to see all the tasks and > compare them to current tasks/artifacts. > - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier > to combine all test results into a single report. > - Generated pom.xml now has correct dependencies/versions > - Script generation is currently hardcoded and not based on sqoop help, as > previously - though added the possiblity of hooking it in later > > > Thanks, > > Anna Szonyi > >
