> On April 23, 2018, 10:33 a.m., Fero Szabo wrote: > > Hi Anna, > > > > I couldn't apply the patch cleanly, I ran into the following error message: > > > > fero-MBP:sqoop ferencszabo$ git apply ~/Downloads/SQOOP-3052-5.patch > > error: missing binary patch data for 'gradle/wrapper/gradle-wrapper.jar' > > error: binary patch does not apply to 'gradle/wrapper/gradle-wrapper.jar' > > error: gradle/wrapper/gradle-wrapper.jar: patch does not apply > > > > Managed to apply it with the following command: > > patch -p1 -i ~/Downloads/SQOOP-3052-5.patch > > > > Also, gradle was missing from my system, so I had to install it and then > > gradle/wrapper/gradle-wrapper.jar was probably downloaded after I executed > > 'gradle wrapper' or './gradlew wrapper' > > > > I'm not sure how to fix these though. Did I go through the "correct" way to > > install gradle? Maybe I should have invoked './gradlew wrapper' right after > > applying the patch. Would that work without gradle installed on the system? > > > > Anyway thanks for the patch, it would be really cool to use gradle in Sqoop! > > Anna Szonyi wrote: > Hi Fero, > > Thanks for testing, I haven't rebased to the latest version of trunk, > which might be the reason it doesn't apply cleanly? I tested it when I > created the patch on the current (at that time) trunk, but I will definitely > double-check this. > > The reason we are adding the gradle wrapper jar and the gradlew and > gradlew.bat files is that you shouldn't have been required to separately > install gradle - just execute ./gradlew wrapper. > > Thanks, > Anna
I've regenerated the diff with the --binary flag as well, which seems to be the solution for your apply issues, the rest of the issues stem from this. - Anna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66067/#review201727 ----------------------------------------------------------- On April 24, 2018, 2:23 p.m., Anna Szonyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66067/ > ----------------------------------------------------------- > > (Updated April 24, 2018, 2:23 p.m.) > > > Review request for Sqoop. > > > Bugs: Sqoop-3052 > https://issues.apache.org/jira/browse/Sqoop-3052 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer > friendly / open > > > Diffs > ----- > > .gitignore 68cbe28731e613607c208824443d1edf256d9c8a > COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5 > build.gradle PRE-CREATION > config/checkstyle/checkstyle-java-header.txt PRE-CREATION > config/checkstyle/checkstyle-noframes.xsl PRE-CREATION > config/checkstyle/checkstyle.xml PRE-CREATION > gradle.properties PRE-CREATION > gradle/customUnixStartScript.txt PRE-CREATION > gradle/customWindowsStartScript.txt PRE-CREATION > gradle/sqoop-package.gradle PRE-CREATION > gradle/sqoop-version-gen.gradle PRE-CREATION > gradle/wrapper/gradle-wrapper.jar PRE-CREATION > gradle/wrapper/gradle-wrapper.properties PRE-CREATION > gradlew PRE-CREATION > gradlew.bat PRE-CREATION > settings.gradle PRE-CREATION > src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556 > testdata/hcatalog/conf/hive-site.xml > edac7aa9087a84b7a0c660907794adae684ae313 > > > Diff: https://reviews.apache.org/r/66067/diff/10/ > > > Testing > ------- > > ran all new tasks, except for internal maven publishing > > Notes: > - To try it out you can call ./gradlew tasks --all to see all the tasks and > compare them to current tasks/artifacts. > - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier > to combine all test results into a single report. > - Generated pom.xml now has correct dependencies/versions > - Script generation is currently hardcoded and not based on sqoop help, as > previously - though added the possiblity of hooking it in later > > > Thanks, > > Anna Szonyi > >
